-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usbguard: 0.7.4 -> 0.7.5 #68080
usbguard: 0.7.4 -> 0.7.5 #68080
Conversation
https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.5 * no longer needs/uses qt as of 0.7.5 * asciidoctor -> asciidoc, drop pandoc (pandoc only seems to be used as part of doc spell-check which we don't enable anyway) * docbook bits
@@ -16527,7 +16527,7 @@ in | |||
|
|||
upower = callPackage ../os-specific/linux/upower { }; | |||
|
|||
usbguard = libsForQt5.callPackage ../os-specific/linux/usbguard { | |||
usbguard = callPackage ../os-specific/linux/usbguard { | |||
libgcrypt = null; | |||
}; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to kill the usbguard-nox
entry on pkgs/top-level/all-packages.nix:16535
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! Added alias to avoid breakage for anyone using usbguard-nox
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
binaries seem to work
leaf package
[3 built, 86 copied (264.0 MiB), 51.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68080
1 package were build:
usbguard
This is a somewhat unfortunate upgrade, because 0.7.4 had a useful and working GUI for allowing or denying a device, while 0.7.5 removed it entirely. USBGuard/usbguard@bf3bb09 says "the Qt applet will be maintained in a separate repository", but I do not see it in http://github.com/USBGuard. |
Motivation for this change
https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.5
(pandoc only seems to be used as part of doc spell-check
which we don't enable anyway)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @