Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: 3.6.6 -> 4.0.3 #68087

Merged
merged 2 commits into from
Sep 5, 2019
Merged

platformio: 3.6.6 -> 4.0.3 #68087

merged 2 commits into from
Sep 5, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Also move to py3. We have provisioning for overriding python packages which was needed for pio3, which is no longer the case as upstream fixed support for click v6, but I am leaving it in, in case we need another override again (likely).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mog @makefu

@mmahut
Copy link
Member

mmahut commented Sep 5, 2019

@GrahamcOfBorg build platformio

@mmahut mmahut merged commit 1a5d105 into NixOS:master Sep 5, 2019
@peterhoeg peterhoeg deleted the u/pio4 branch September 5, 2019 07:40
@peterhoeg peterhoeg restored the u/pio4 branch September 6, 2019 06:22
@peterhoeg peterhoeg deleted the u/pio4 branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the u/pio4 branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the u/pio4 branch September 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants