Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.textacy: 0.6.3 -> 0.9.1 #68093

Merged
merged 1 commit into from
Sep 5, 2019
Merged

python3Packages.textacy: 0.6.3 -> 0.9.1 #68093

merged 1 commit into from
Sep 5, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 4, 2019 •
edited
Loading

Motivation for this change

textacy enabled support for scikitlearn>=0.21 with chartbeat-labs/textacy#260, so it can now be added back.

changelog: https://github.com/chartbeat-labs/textacy/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rvl

it has matpotlib, scipy, scikitlearn, it's a big closure

# it was broken before
$ nix path-info -Sh ./result
/nix/store/qv94zfd077rqs4pf9l0w2wm6aw57ff1k-python3.7-textacy-0.9.1      783.4M

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68093
1 package were build:
python37Packages.textacy

rvl
rvl approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mmahut
Copy link
Member

mmahut commented Sep 5, 2019

@GrahamcOfBorg build python3Packages.textacy pythonPackages.textacy

@mmahut mmahut merged commit 88c42a2 into NixOS:master Sep 5, 2019
@jonringer jonringer deleted the bump-textacy branch September 5, 2019 16:16
@mattmelling mattmelling mentioned this pull request Sep 8, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonringer @mmahut @rvl