Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luarocks nix bump #68258

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Luarocks nix bump #68258

merged 3 commits into from
Sep 9, 2019

Conversation

teto
Copy link
Member

@teto teto commented Sep 7, 2019

Motivation for this change

According to #68158, it seems like update-luarocks-packages will return different urls depending on the mirror hit.
I've thus proceeded to rebase luarocks-nix on top of the new luarocks-release 3.2.1 #68201 and added support for the generation of
mirror://luarocks/<PACKAGE_NAME> when possible.
The updater will also now look into a specific LUAROCKS_CONFIG to prevent outside impurities.
It allows to set some settings to let it perform better.

I've successfully regenerated a pkgs/development/lua-modules/generated-packages.nix with this.
Seems like package installation works with the new mirror://luarocks uris. (except for penlight).
I haven't submitted the pkgs/development/lua-modules/generated-packages.nix changes, I prefer to let it update itself little by little :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

we now pass a configuration file when calling luarocks to prevent
impurities.
luarocks defines by default the following mirrors:
https://github.com/luarocks/luarocks/blob/83093e7da7f789f0f7d3a6784597cbbed09c73e0/src/luarocks/core/cfg.lua#L205

Let's add them to nixpkgs. I have modified luarocks-nix to generate the
proper nixpkgs urls.
I bump luarocks-nix in the following commits.
@ofborg ofborg bot added the 6.topic: fetch label Sep 7, 2019
@teto
Copy link
Member Author

teto commented Sep 7, 2019

CC @Shados . while running the update script I had a few issues because parallel tends to hide the error. I just see:

parallel: This job failed:
convert_pkg cyrussasl '' '' '' '' vcunat
*** error 1: tee -a "$TMP_FILE".

without being able to retrieve the error message. I don't know parallel but I wondered if the situation could be improved ?

@ofborg ofborg bot requested a review from 7c6f434c September 7, 2019 12:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2019
@Shados
Copy link
Member

Shados commented Sep 7, 2019

@teto the way parallel is set up, it should still output all the stdout/stderr for the called function, but it will do so in the order that the calls are made, so you may need to scrollback a bit to find the output for the failing call.

@teto
Copy link
Member Author

teto commented Sep 7, 2019

cc @doronbehar since you are a lua user :)

added version and transferred the repostiory to nix-community.
With this bump, luarocks-nix generates mirro://luarocks urls.
@teto
Copy link
Member Author

teto commented Sep 9, 2019

due to moving luarocks-nix to nix-community, luarocks-nix is broken in nixpkgs so I will merge this since in my tests it work. If there is an issue, I will fix it.

@teto teto merged commit 59d65e2 into NixOS:master Sep 9, 2019
@teto teto deleted the luarocks-nix_bump branch September 9, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants