-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luarocks nix bump #68258
Luarocks nix bump #68258
Conversation
we now pass a configuration file when calling luarocks to prevent impurities.
luarocks defines by default the following mirrors: https://github.com/luarocks/luarocks/blob/83093e7da7f789f0f7d3a6784597cbbed09c73e0/src/luarocks/core/cfg.lua#L205 Let's add them to nixpkgs. I have modified luarocks-nix to generate the proper nixpkgs urls. I bump luarocks-nix in the following commits.
CC @Shados . while running the update script I had a few issues because parallel tends to hide the error. I just see:
without being able to retrieve the error message. I don't know parallel but I wondered if the situation could be improved ? |
@teto the way parallel is set up, it should still output all the stdout/stderr for the called function, but it will do so in the order that the calls are made, so you may need to scrollback a bit to find the output for the failing call. |
cc @doronbehar since you are a lua user :) |
added version and transferred the repostiory to nix-community. With this bump, luarocks-nix generates mirro://luarocks urls.
27806a1
to
4a31890
Compare
due to moving luarocks-nix to nix-community, luarocks-nix is broken in nixpkgs so I will merge this since in my tests it work. If there is an issue, I will fix it. |
Motivation for this change
According to #68158, it seems like update-luarocks-packages will return different urls depending on the mirror hit.
I've thus proceeded to rebase luarocks-nix on top of the new luarocks-release 3.2.1 #68201 and added support for the generation of
mirror://luarocks/<PACKAGE_NAME> when possible.
The updater will also now look into a specific LUAROCKS_CONFIG to prevent outside impurities.
It allows to set some settings to let it perform better.
I've successfully regenerated a pkgs/development/lua-modules/generated-packages.nix with this.
Seems like package installation works with the new mirror://luarocks uris. (except for penlight).
I haven't submitted the pkgs/development/lua-modules/generated-packages.nix changes, I prefer to let it update itself little by little :)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @