Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.{dlib,face_recognition_models}: fix build/startup #68787

Merged
merged 2 commits into from
Sep 14, 2019
Merged

pythonPackages.{dlib,face_recognition_models}: fix build/startup #68787

merged 2 commits into from
Sep 14, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 14, 2019 •
edited
Loading

Motivation for this change

Fixes dlib and face_recognition_models:

  • 72ec538: fix dlib by skipping cmake configuration.
  • e176117: fix runtime of face_recognition_models by propagating setuptools.

ZHF #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
python3Packages.dlib: fix build
72ec538 
The CMake configuring is done in the `setup.py` and doesn't need to be
done by the setup hook. This broke the build as the setup-hook switches
into `source/build` which doesn't have a `setup.py`.

Relying on the setup script from upstream fixes the issue.

ZHF NixOS#68361
@Ma27
python3Packages.face_recognition_models: fix startup
e176117
@Ma27 Ma27 requested a review from FRidh as a code owner September 14, 2019 12:05
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 14, 2019
@WilliButz WilliButz self-assigned this Sep 14, 2019
@WilliButz WilliButz merged commit 9128fe1 into NixOS:master Sep 14, 2019
@Ma27 Ma27 deleted the fix-python-dlib branch September 14, 2019 12:48
@WilliButz
Copy link
Member

backported in c1f47a5 and 5e1b7b6

@WilliButz WilliButz removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@WilliButz WilliButz

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ma27 @WilliButz