Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyperf: 1.6.0 -> 1.6.1 #68866

Merged
merged 1 commit into from
Sep 18, 2019
Merged

pythonPackages.pyperf: 1.6.0 -> 1.6.1 #68866

merged 1 commit into from
Sep 18, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 15, 2019

Motivation for this change

perf was renamed to pyperf [1] to avoid confusion with Linux perf
project.

[1] psf/pyperf@60eb936

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @costrouc

@marsam
pythonPackages.pyperf: 1.6.0 -> 1.6.1
ebdaba7 
perf was renamed to pyperf [1] to avoid confusion with Linux perf
project.

[1] psf/pyperf@60eb936
@marsam marsam requested a review from FRidh as a code owner September 15, 2019 21:10
@ofborg ofborg bot requested a review from costrouc September 15, 2019 21:27
@B4dM4n
Copy link
Contributor

B4dM4n commented Sep 16, 2019

LGTM.

Builds fine as python2Packages.pyperf and python3Packages.pyperf.

nix-review shows no dependent packages.

@marsam marsam merged commit 9d09cf0 into NixOS:master Sep 18, 2019
@marsam marsam deleted the update-python-pyperf branch September 18, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsam @B4dM4n