Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-inspect: fix build on Darwin #68966

Merged
merged 1 commit into from
Sep 18, 2019
Merged

cargo-inspect: fix build on Darwin #68966

merged 1 commit into from
Sep 18, 2019

Conversation

siriobalmelli
Copy link
Contributor

@siriobalmelli siriobalmelli commented Sep 17, 2019 •
edited
Loading

cargo-inspect: fix build on Darwin

package fails to build with 'ld: framework not found Security'
Solve by adding darwin.apple_sdk.frameworks.Security on Darwin.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

Tried to build on Darwin and failed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 17, 2019
@siriobalmelli
cargo-inspect: fix build on Darwin
7cb3992 
package fails to build with 'ld: framework not found Security'
Solve by adding darwin.apple_sdk.frameworks.Security on Darwin.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@marsam marsam merged commit f1747f0 into NixOS:master Sep 18, 2019
@marsam
Copy link
Contributor

marsam commented Sep 18, 2019

Thank you @siriobalmelli

@siriobalmelli siriobalmelli deleted the fix/cargo-inspect branch September 20, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siriobalmelli @marsam