Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkvtoolnix: fix build with clang #69006

Merged
merged 1 commit into from
Sep 18, 2019
Merged

mkvtoolnix: fix build with clang #69006

merged 1 commit into from
Sep 18, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 18, 2019

Motivation for this change

Fixes #68928
cc: @bdesham

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from rnhmjoj and Fuuzetsu September 18, 2019 03:56
jonringer
jonringer approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[5 built, 21 copied (286.7 MiB), 41.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69006
2 package were build:
mkvtoolnix mkvtoolnix-cli

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 18, 2019

@GrahamcOfBorg build mkvtoolnix-cli

@bdesham
Copy link
Contributor

bdesham commented Sep 18, 2019

This works for me! Thank you 😀

rnhmjoj
rnhmjoj approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ofBorg is not running the builds... Well, I trust you it runs on darwin.

@marsam marsam merged commit 6890d08 into NixOS:master Sep 18, 2019
@marsam marsam deleted the fix-mkvtoolnix branch September 18, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mkvtoolnix does not build on Darwin
4 participants
@marsam @rnhmjoj @bdesham @jonringer