Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librecad: 2.1.3 -> 2.2.0-rc1 #69077

Merged
merged 1 commit into from
Sep 23, 2019
Merged

librecad: 2.1.3 -> 2.2.0-rc1 #69077

merged 1 commit into from
Sep 23, 2019

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Sep 19, 2019 •
edited
Loading

Motivation for this change

2.2.0 moves to qt5 from qt4, so it looks much nicer on a hidpi screen. rc1 is considered stable by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @viric

@peterhoeg
librecad: 2.1.3 -> 2.2.0-rc1
454b052 
rc1 is considered stable by upstream.
@ofborg ofborg bot requested a review from viric September 19, 2019 05:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 19, 2019
@peterhoeg
Copy link
Member Author

#33248

@peterhoeg peterhoeg merged commit 3b8a232 into NixOS:master Sep 23, 2019
@peterhoeg peterhoeg deleted the u/librecad branch September 23, 2019 03:29
@peterhoeg peterhoeg restored the u/librecad branch September 25, 2019 10:28
@peterhoeg peterhoeg deleted the u/librecad branch September 26, 2019 13:42
@lightbulbjim lightbulbjim mentioned this pull request Oct 25, 2019
Merged
10 tasks
@yvesf yvesf mentioned this pull request Jan 21, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterhoeg