Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.sentry-sdk: Fix tests #69142

Merged
merged 2 commits into from
Sep 21, 2019
Merged

python37Packages.sentry-sdk: Fix tests #69142

merged 2 commits into from
Sep 21, 2019

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Sep 20, 2019

Fix python37Packages.sentry-sdk, part of #68361 (zero Hydra failures).

This package failed to build because its test suite depends on many third-party packages that Sentry offers integration with if you depend on that package anyway. The test suite tests all of these, but they are not required at runtime unless you already use them, so I added them as buildInputs.

Motivation for this change

#68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) — there are none
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gebner

@ruuda
python37Packages.sentry-sdk: Fix tests
ce6145d 
The tests depend on many third-party libraries, presumably because
Sentry offers integration for each of them. I added these as build
inputs but not propagated build inputs, because they are only needed for
the tests.
@ruuda ruuda requested a review from FRidh as a code owner September 20, 2019 09:09
@ofborg ofborg bot requested a review from gebner September 20, 2019 09:21
@delroth
Copy link
Contributor

delroth commented Sep 20, 2019

Wouldn't checkInputs be better than buildInputs if these are only required for the checkPhase?

@ruuda
python37Packages.sentry-sdk: use checkInputs
8a9ebc0 
Instead of buildInputs, as there dependencies are only used in tests.
@ruuda
Copy link
Contributor Author

ruuda commented Sep 21, 2019

Ah, I was not aware of checkInputs, thanks for pointing that out. Fixed now.

@Mic92 Mic92 merged commit e03ef7f into NixOS:master Sep 21, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

[detached HEAD 1abe649] python37Packages.sentry-sdk: Fix tests
Author: Ruud van Asseldonk dev@veniogames.com
Date: Fri Sep 20 11:03:18 2019 +0200
1 file changed, 3 insertions(+), 1 deletion(-)
Press Enter to continue
[detached HEAD 6687613] python37Packages.sentry-sdk: use checkInputs
Author: Ruud van Asseldonk dev@veniogames.com
Date: Sat Sep 21 09:02:20 2019 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruuda @delroth @Mic92