Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amule: cleanup #69275

Merged
merged 1 commit into from
Sep 24, 2019
Merged

amule: cleanup #69275

merged 1 commit into from
Sep 24, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Cleanups.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Phreedom

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 23, 2019
@ofborg ofborg bot requested a review from Phreedom September 23, 2019 03:33
jonringer
jonringer approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[6 built, 5 copied (33.9 MiB), 8.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69275
3 package were build:
amule amuleDaemon amuleGui

@peterhoeg peterhoeg merged commit c5e5974 into NixOS:master Sep 24, 2019
@peterhoeg peterhoeg deleted the f/amule branch September 24, 2019 02:50
@peterhoeg peterhoeg restored the f/amule branch September 25, 2019 10:28
@peterhoeg peterhoeg deleted the f/amule branch September 25, 2019 10:53
@peterhoeg peterhoeg restored the f/amule branch September 26, 2019 13:17
@peterhoeg peterhoeg deleted the f/amule branch September 26, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhoeg @jonringer