manticore: 2018.09.29 -> 2019.09.20 #69350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
@GrahamcOfBorg build manticore |
|
It also seems to install its source: |
|
That was added in 53dde42#diff-d44f3788bd35dd171c6fc74abc8da4d5 and seems to be intentional. I admit I don't know what goes wrong without this, though. |
alyssais
requested changes
Sep 24, 2019
| @@ -1,15 +1,15 @@ | |||
| { stdenv, fetchFromGitHub, coreutils, autoreconfHook, smlnj }: | |||
|
|
|||
| let | |||
| rev= "47273c463fc3c5d0a0ae655cf75a4700bdb020b4"; | |||
| rev= "4528ccacdfd53d36f5959c005b27cd7ab6175b83"; | |||
| in stdenv.mkDerivation { | |||
| pname = "manticore"; | |||
There was a problem hiding this comment.
Suggested change
| pname = "manticore"; | |
| pname = "manticore-unstable"; |
| @@ -1,15 +1,15 @@ | |||
| { stdenv, fetchFromGitHub, coreutils, autoreconfHook, smlnj }: | |||
|
|
|||
| let | |||
| rev= "47273c463fc3c5d0a0ae655cf75a4700bdb020b4"; | |||
| rev= "4528ccacdfd53d36f5959c005b27cd7ab6175b83"; | |||
There was a problem hiding this comment.
Shall we just put this in with the rest of fetchFromGitHub while we’re here? Not sure what it’s doing up here.
| in stdenv.mkDerivation { | ||
| pname = "manticore"; | ||
| version = "2018.09.29"; | ||
| version = "2019.09.20"; |
There was a problem hiding this comment.
Suggested change
| version = "2019.09.20"; | |
| version = "2019-09-20"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
manticorewasn't building on master or 19.09. This upgrade fixes that.Connected to #68361
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @