Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 12.2.0 -> 12.3.0 #69417

Merged
merged 1 commit into from
Sep 25, 2019
Merged

gitlab-runner: 12.2.0 -> 12.3.0 #69417

merged 1 commit into from
Sep 25, 2019

Conversation

max-wittig
Copy link
Contributor

@max-wittig max-wittig commented Sep 25, 2019 •
edited
Loading

Motivation for this change

Update to latest version.

See: https://gitlab.com/gitlab-org/gitlab-runner/blob/v12.3.0/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bachp @zimbatm @globin

@globin globin merged commit 1f4e9c6 into NixOS:master Sep 25, 2019
@max-wittig
Copy link
Contributor Author

@globin Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-wittig @globin