Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.pcov: init at 1.0.6 #70068

Merged
merged 1 commit into from
Oct 27, 2019
Merged

phpPackages.pcov: init at 1.0.6 #70068

merged 1 commit into from
Oct 27, 2019

Conversation

shyim
Copy link
Member

@shyim shyim commented Sep 30, 2019

Motivation for this change

pcov can be used instead xdebug for code coverage (https://github.com/krakjoe/pcov). Its much faster in generating instead xdebug

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 30, 2019
@aanderse
Copy link
Member

@GrahamcOfBorg build php72Packages.pcov php73Packages.pcov
@etu @Izorkin @Ma27 anyone familiar with this package?

@etu
Copy link
Contributor

etu commented Oct 27, 2019

@aanderse Not familiar with it, but if it builds fine I don't see any big problems with it

@etu etu merged commit 32c47ab into NixOS:master Oct 27, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
@etu @dtzWill
Merge pull request NixOS#70068 from shyim/add-pcov
7e0b9b0 
phpPackages.pcov: init at 1.0.6

(cherry picked from commit 32c47ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyim @aanderse @etu