-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourcehut.*: 2019.10.02 #70255
sourcehut.*: 2019.10.02 #70255
Conversation
nix-review reports:
|
That's an unrelated issue to sourcehut, it's due the hash of the patch from Github being changed, it's fixed by the #70256. |
8baea14
to
4d8bda8
Compare
@GrahamcOfBorg eval |
You may want to rebase from master as sourcehut is currently marked as broken there since #70256. |
Why does sourcehut require node anyways? Isn't it one of the selling points of sourcehut that it runs without JS? |
It looks like it's just for minifying files, it doesn't require node, but uses npm to download clean-css. |
Specifically, it's called when generating the static sources I'm pretty sure [1]. [1] https://git.sr.ht/~sircmpwn/core.sr.ht/tree/master/srht/Makefile#L25 |
Reupdated and rebased to master. |
4d8bda8
to
755bb73
Compare
755bb73
to
55d5a90
Compare
@GrahamcOfBorg build sourcehut.gitsrht sourcehut.mansrht sourcehut.hgsrht sourcehut.todosrht sourcehut.dispatchsrht sourcehut.pastesrht sourcehut.buildsrht sourcehut.listssrht sourcehut.metasrht |
Builds after #69066 or should build after #70256 as well.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @