Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.SessionToken: init at 1.503 #70328

Merged
merged 1 commit into from
Oct 14, 2019
Merged

perlPackages.SessionToken: init at 1.503 #70328

merged 1 commit into from
Oct 14, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc requested a review from volth October 3, 2019 14:24
@stigtsp stigtsp force-pushed the package/perl-session-token-init branch from 20980d8 to ca47ada Compare October 3, 2019 15:24
c0bw3b
c0bw3b approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 70328 1

2 package were build:
  • perl528Packages.SessionToken
  • perl530Packages.SessionToken

@c0bw3b c0bw3b merged commit be5f498 into NixOS:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stigtsp @c0bw3b