Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{v8, v8_6_x}: fix log output exceeded w. GCC8 #70598

Merged
merged 1 commit into from
Oct 12, 2019
Merged

{v8, v8_6_x}: fix log output exceeded w. GCC8 #70598

merged 1 commit into from
Oct 12, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Oct 7, 2019

Motivation for this change

This reduces the log size to ~1MB.

Similar to: #68434
Related: #68361

Failing builds:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin
{v8, v8_6_x}: fix log output exceeded w. GCC8
2a1f302 
This reduces the log size to ~1MB.
@ofborg ofborg bot requested review from matthewbauer and cstrahan October 7, 2019 09:42
@joachifm joachifm merged commit 48724c7 into NixOS:master Oct 12, 2019
@d-goldin d-goldin deleted the fix_v8_gcc8_log branch October 12, 2019 13:04
vcunat pushed a commit that referenced this pull request Oct 12, 2019
@joachifm @vcunat
Merge #70598: {v8, v8_6_x}: fix log output exceeded w. GCC8
ce0a540 
(cherry picked from commit 48724c7)
@vcunat vcunat added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-goldin @joachifm @vcunat