Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.slither-analyzer: add setuptools #70870

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

noticed it was broken while reviewing #70779

before:

slither --help
Traceback (most recent call last):
  File "/nix/store/avcqq2i4qxrq0q88lcfjcqwp5kwncsc0-python3.7-slither-analyzer-0.3.0/bin/.slither-wrapped", line 7, in <module>
    from slither.__main__ import main
  File "/nix/store/avcqq2i4qxrq0q88lcfjcqwp5kwncsc0-python3.7-slither-analyzer-0.3.0/lib/python3.7/site-packages/slither/__main__.py", line 12, in <module>
    from pkg_resources import iter_entry_points, require
ModuleNotFoundError: No module named 'pkg_resources'

after:

$ slither --help
usage: slither.py contract.sol [flag]

Slither

positional arguments:
....
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 9, 2019 17:21
@ofborg ofborg bot requested a review from asymmetric October 9, 2019 17:38
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing these @jonringer ❇️

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with no issues.

@worldofpeace worldofpeace merged commit 646b519 into NixOS:master Oct 9, 2019
@worldofpeace
Copy link
Contributor

backported in dd0fac6

@jonringer jonringer deleted the fix-slither-analyzer branch October 9, 2019 19:31
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants