Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: use regular qt5 #71076

Merged
merged 1 commit into from
Oct 13, 2019
Merged

zoom-us: use regular qt5 #71076

merged 1 commit into from
Oct 13, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 13, 2019

zoom-us used to be not compatible with the current qt5 version
provided by libsForQt5.callPackage, but it is by now.

To avoid downloading a different qt (or even building it), point it back
to the generic libsForQt5.callPackage.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @grahamc @worldofpeace @NeQuissimus

@flokli
zoom-us: use regular qt5
a64fcdc 
`zoom-us` used to be not compatible with the current qt5 version
provided by `libsForQt5.callPackage`, but it is by now.

To avoid downloading a different qt (or even building it), point it back
to the generic `libsForQt5.callPackage`.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 13, 2019
@NeQuissimus NeQuissimus merged commit 5294227 into NixOS:master Oct 13, 2019
@worldofpeace
Copy link
Contributor

Thanks, wasn't sure we needed to do this before 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flokli @worldofpeace @NeQuissimus