Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire-desktop: linux 3.10.2904 -> 3.11.2912 #72375

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Oct 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@ofborg ofborg bot requested a review from worldofpeace October 31, 2019 18:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 31, 2019
@worldofpeace worldofpeace merged commit 59edabf into NixOS:master Nov 3, 2019
@worldofpeace
Copy link
Contributor

I've done some backports to 19.09

I'll probably try to do these regularly for wire-desktop, I also try to read their release notes/changelogs

@toonn
Copy link
Contributor Author

toonn commented Nov 3, 2019

@worldofpeace, let me know if I can somehow help with that. Should I open a PR on the 19.09 branch too, for example? Anything specific you want me to keep an eye out for in the changelogs?

@worldofpeace
Copy link
Contributor

@worldofpeace, let me know if I can somehow help with that. Should I open a PR on the 19.09 branch too, for example? Anything specific you want me to keep an eye out for in the changelogs?

Yep, opening a PR to the 19.09 branch with commit git cherry-pick -x would be great.
As for the changelogs, only serious breaking change.
Because it's like a web app, we'll probably keep an exception open for it as far as backports. IIRC this app would break at a certain point of being out of date, or if they changed something in their servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants