Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vapoursynth: R47.2 -> R48 #72398

Merged
merged 1 commit into from
Nov 2, 2019
Merged

vapoursynth: R47.2 -> R48 #72398

merged 1 commit into from
Nov 2, 2019

Conversation

tadeokondrak
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from rnhmjoj November 1, 2019 00:24
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 1, 2019
rnhmjoj
rnhmjoj approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the usual stuff: vspipe and mpv. Looks all right.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 1, 2019 •
edited
Loading

Btw, vapoursynth-editor needs to be wrapped: see #65399.

@tadeokondrak
Copy link
Contributor Author

Btw, vapoursynth-editor needs to be wrapper: see #65399.

Thanks, #72465

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/64

@marsam marsam merged commit e0699ce into NixOS:master Nov 2, 2019
@marsam
Copy link
Contributor

marsam commented Nov 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tadeokondrak @rnhmjoj @nixos-discourse @marsam