Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spacy to 2.2.2 + necessary dependency updates #72552

Merged
merged 4 commits into from
Nov 3, 2019
Merged

Update spacy to 2.2.2 + necessary dependency updates #72552

merged 4 commits into from
Nov 3, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 2, 2019

Motivation for this change

Update spaCy to 2.2.2, this PR also bundles the necessary updates to dependencies of spaCy.

Tested using the en_core_web_sm model.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
python3Packages.thinc: 7.2.0 -> 7.3.1
fed908b 
Largest changes:

- Add Mish activation.
- Add experimental support for the RAdam optimizer.
- Add experimental support for lookahead to the optimizer.
- Add experimental support for LARS to the optimizer.

Changelog:
https://github.com/explosion/thinc/releases/tag/v7.3.0
@danieldk
python3Packages.srsly: 0.1.0 -> 0.2.0
e82694c 
Changelog:
https://github.com/explosion/srsly/releases/tag/v0.2.0
@danieldk
python3Packages.wasabi: 0.2.2 -> 0.3.0
bf55216 
Changelog:
https://github.com/ines/wasabi/releases/tag/v0.3.0
@danieldk
python3Packages.spacy: 2.2.1 -> 2.2.2
d91deba 
Major changes:

- Multiprocessing support in nlp.pipe.
- Base language support for Luxembourgish.

Changelog:
https://github.com/explosion/spaCy/releases/tag/v2.2.2
@danieldk
Copy link
Contributor Author

danieldk commented Nov 2, 2019

@GrahamcOfBorg build python3Packages.spacy

@ofborg ofborg bot requested a review from aborsu November 2, 2019 09:24
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 2, 2019
@danieldk danieldk mentioned this pull request Nov 3, 2019
Closed
@ryantm
Copy link
Member

ryantm commented Nov 3, 2019

spacy was already failing on aarch64-linux, nix-review passes

@ryantm ryantm merged commit 5d5dfbf into NixOS:master Nov 3, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 4, 2019
@ryantm @dtzWill
Merge pull request NixOS#72552 from danieldk/spacy-2.2.2
954a958 
Update spacy to 2.2.2 + necessary dependency updates

(cherry picked from commit 5d5dfbf)
@danieldk danieldk deleted the spacy-2.2.2 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldk @ryantm