Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellinabox: fix CVE-2018-16789 #72620

Merged
merged 1 commit into from
Nov 3, 2019
Merged

shellinabox: fix CVE-2018-16789 #72620

merged 1 commit into from
Nov 3, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 2, 2019

Motivation for this change

Provide shellinabox patched against a simple DoS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tomberek @lihop

@c0bw3b c0bw3b added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 2, 2019
@ofborg ofborg bot requested a review from tomberek November 2, 2019 21:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Nov 2, 2019
tomberek
tomberek approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@c0bw3b c0bw3b merged commit 73523e0 into NixOS:master Nov 3, 2019
@c0bw3b c0bw3b deleted the pkg/shellinabox branch November 3, 2019 15:50
c0bw3b added a commit that referenced this pull request Nov 3, 2019
@c0bw3b
shellinabox: fix CVE-2018-16789
5def3c8 
(#72620)

(cherry picked from commit 73523e0)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@c0bw3b @dtzWill
shellinabox: fix CVE-2018-16789
2ab01c4 
(NixOS#72620)

(cherry picked from commit 73523e0)
@lihop lihop mentioned this pull request Oct 7, 2020
Closed
1 task
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c0bw3b @marsam @tomberek @TredwellGit