Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria2: 1.34.0 -> 1.35.0 #73220

Merged
merged 2 commits into from
Nov 13, 2019
Merged

aria2: 1.34.0 -> 1.35.0 #73220

merged 2 commits into from
Nov 13, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 11, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @k0ral

This change is Reviewable

@Br1ght0ne Br1ght0ne changed the title Aria2 1.35.0 aria2: 1.34.0 -> 1.35.0 Nov 11, 2019
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 11, 2019
@k0ral
Copy link
Contributor

k0ral commented Nov 11, 2019

LGTM.
Thank you ! :)

c0bw3b
c0bw3b approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

Result of nix-review pr 73220 1

1 package are marked as broken and were skipped:
  • kiwix (aria2)
4 package were build:
  • aria (aria2)
  • persepolis (aria2)
  • uget (aria2)
  • uget-integrator (aria2)

@c0bw3b c0bw3b merged commit 4f3c2a2 into NixOS:master Nov 13, 2019
@Br1ght0ne Br1ght0ne deleted the aria2-1.35.0 branch November 13, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Br1ght0ne @k0ral @c0bw3b