Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickjs: init at 2019-10-27 #73515

Merged
merged 3 commits into from
Nov 17, 2019
Merged

quickjs: init at 2019-10-27 #73515

merged 3 commits into from
Nov 17, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Nov 16, 2019

Motivation for this change

Add quickjs. This is based on #64668 but bumps the version and adds an installCheckPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @stesie
#64668 reviewers @tadeokondrak @worldofpeace

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 16, 2019
@ofborg ofborg bot requested a review from stesie November 16, 2019 19:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 16, 2019
@ghost
Copy link

ghost commented Nov 17, 2019

Built on NixOS x86_64-linux, and tested execution of all binaries in bin/.
Looks fine to me 👍

@ghost
Copy link

ghost commented Nov 17, 2019

@GrahamcOfBorg build quickjs

@ryantm ryantm merged commit 106d404 into NixOS:master Nov 17, 2019
@ryantm
Copy link
Member

ryantm commented Nov 17, 2019

Thanks!

@timokau timokau mentioned this pull request Dec 4, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stesie stesie Awaiting requested review from stesie

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan @ryantm @stesie