Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeFrameworks.kio: moving bin stuff into "out" output #73926

Merged
merged 1 commit into from
Nov 24, 2019
Merged

kdeFrameworks.kio: moving bin stuff into "out" output #73926

merged 1 commit into from
Nov 24, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Nov 22, 2019

Motivation for this change

Moving the bin stuff into "out" output to force the wrapQtAppsHook to wrap also stuff in libexec/kf5.

Unwrapped kiod5 caused a number of issues, such as viewing Android phones on Dolphin (fixes
#71509) or Samba shares (fixes #72150)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@mmahut mmahut requested a review from ttuegel as a code owner November 22, 2019 16:39
@mmahut mmahut added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 22, 2019
@worldofpeace worldofpeace merged commit c24ce71 into NixOS:master Nov 24, 2019
@worldofpeace
Copy link
Contributor

backported in 9d8a925

@1000101 1000101 mentioned this pull request Nov 28, 2019
Closed
@oxalica oxalica mentioned this pull request Feb 11, 2020
Closed
@tobiasBora tobiasBora mentioned this pull request Aug 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kpasswdserver broken on 19.09
3 participants
@mmahut @worldofpeace @1000101