Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crun: 0.8 -> 0.10.6, addressing CVE-2019-18837 #75304

Merged
merged 1 commit into from
Dec 14, 2019
Merged

crun: 0.8 -> 0.10.6, addressing CVE-2019-18837 #75304

merged 1 commit into from
Dec 14, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 8, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-18837

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Dec 8, 2019
@c0bw3b c0bw3b added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 12, 2019
c0bw3b
c0bw3b approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 75304 1

1 package were build:
  • crun

@c0bw3b c0bw3b merged commit 46460d3 into NixOS:master Dec 14, 2019
@c0bw3b c0bw3b removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 14, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 14, 2019

No need to backport, the package is not part of the 19.09 release

clayrat pushed a commit to clayrat/nixpkgs that referenced this pull request Dec 14, 2019
@risicle @clayrat
crun: 0.8 -> 0.10.6 (security) (NixOS#75304)
db42743 
addressing CVE-2019-18837
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 23, 2020
@risicle @dtzWill
crun: 0.8 -> 0.10.6 (security) (NixOS#75304)
12b214e 
addressing CVE-2019-18837

(cherry picked from commit 46460d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @c0bw3b