Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/gitea: test basic git workflow #75492

Merged
merged 2 commits into from
Dec 12, 2019
Merged

nixos/tests/gitea: test basic git workflow #75492

merged 2 commits into from
Dec 12, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 11, 2019

Motivation for this change

A while ago I thought that (automated) package-updates may be even safer if we provide test-cases that check at least the basic functionality of it, so I thought, I'd give it a try with gitea. This test creates a single git repository on one machine, pushes it to a gitea server via ssh and a second machine tries to clone the repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
nixos/gitea: simplify test
8264d7e 
This reduces the length of the gitea-test by creating a single
`makeGiteaTest` function which creates the configuration for a testcase
with a given database driver.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Dec 11, 2019
kolaente
kolaente reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit, looks great otherwise!

nixos/tests/gitea.nix Show resolved Hide resolved
aanderse
aanderse approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! This test is a great example of a thorough NixOS test. Next time we're in same zip code remind me to buy you a beer! 🍻

nixos/tests/gitea.nix Outdated Show resolved Hide resolved
nixos/tests/gitea.nix Outdated Show resolved Hide resolved
@WilliButz WilliButz merged commit 6f0ec16 into NixOS:master Dec 12, 2019
@Ma27 Ma27 deleted the refactor-gitea-test branch December 12, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolaente kolaente kolaente left review comments

@aanderse aanderse aanderse approved these changes

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ma27 @aanderse @kolaente @WilliButz