vscode-extensions.ms-vscode-remote.remote-ssh: init at 0.48.0

[tbenst]

Motivation for this change

Currently, using VSCode extension remote-ssh with NixOS host requires an annoying patch. This client-side patch changes the package so the host node (as found by which node) is always used.

Main limitation: prior to patch, you could remote-ssh to Ubuntu without nodejs_12 installed, and it would work by locally installing node binary. With this patch, you'll need to first sudo apt install nodejs or install nodejs in userspace via another means.

Benefit: as long as a NixOS box has nodejs-12_x installed, it now works out-of-the-box with remote-ssh. As does any other old OS, so this effectively fixes microsoft/vscode-remote-release#103.

Closes nix-community/home-manager#939

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

Not maintainers, but following people may have input:
cc @simonchatts @luxferresum @aanderse @Mic92

[Mic92]

Also mentioned in the wiki: https://nixos.wiki/wiki/Vscode

[tbenst]

Hey @Mic92, apologies but this pull request has a mistake--I neglected to escape the ${ so trigger template javascript. My latest https://github.com/tbenst/nixpkgs/tree/remote-ssh has the fix (including one for useLocalExtensions as well) and is fully functional. Sorry for the hassle

[Mic92]

Can you make a pull request with the fix?