Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ocamlPackages.cppo: 1.6.5 -> 1.6.6" #76942

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Revert "ocamlPackages.cppo: 1.6.5 -> 1.6.6" #76942

merged 1 commit into from
Jan 4, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 4, 2020

Motivation for this change

cppo 1.6.6 breaks building it with ocaml 4.02, which is still required
for some packages.

This reverts commit 000f19f.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Revert "ocamlPackages.cppo: 1.6.5 -> 1.6.6"
5d01fd4 
cppo 1.6.6 breaks building it with ocaml 4.02, which is still required
for some packages.

This reverts commit 000f19f.
@marsam
Copy link
Contributor Author

marsam commented Jan 4, 2020

@GrahamcOfBorg build trv

@marsam marsam mentioned this pull request Jan 4, 2020
Merged
10 tasks
@marsam marsam merged commit 68a5472 into NixOS:master Jan 4, 2020
@marsam marsam deleted the revert-ocaml-cppo branch January 4, 2020 17:11
@vbgl
Copy link
Contributor

vbgl commented Jan 5, 2020

BTW, is trv maintained? Will it be made compatible with recent versions of OCaml? Otherwise, should it be removed from nixpkgs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsam @vbgl