Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctop: 0.7.2 -> 0.7.3 #76957

Merged
merged 1 commit into from
Jan 6, 2020
Merged

ctop: 0.7.2 -> 0.7.3 #76957

merged 1 commit into from
Jan 6, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 4, 2020

Motivation for this change

Changelog: https://github.com/bcicen/ctop/releases/tag/v0.7.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from apeyroux and kalbasit January 4, 2020 23:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 4, 2020
stigtsp
stigtsp approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Tested ctop on docker.

Result of nixpkgs-review pr 76957 1

1 package built:
  • ctop

@marsam marsam merged commit ebd204e into NixOS:master Jan 6, 2020
@marsam marsam deleted the update-ctop branch January 6, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeyroux apeyroux apeyroux approved these changes

@stigtsp stigtsp stigtsp approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @stigtsp @apeyroux