Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildRustCrate: fixup usage of builtins.filterSource #77153

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

andir
Copy link
Member

@andir andir commented Jan 6, 2020

Motivation for this change

While unifying most of the lib function calls I accidentially changed
the filterSource functions as well. Since there were no tests I ended
up forgetting about this case (even thought I ran into it…).

https://github.com/NixOS/nixpkgs/pull/75563/files/0aac0e8d2c9c129bf1ed868bdc735b738b17b44e#r363462659

@xzfc Can you verify that this solves your problem?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

While unifying most of the lib function calls I accidentially changed
the filterSource functions as well. Since there were no tests I ended
up forgetting about this case (even thought I ran into it…).
@andir
Copy link
Member Author

andir commented Jan 6, 2020

@GrahamcOfBorg buildRustCrateTests

@ofborg ofborg bot added 6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2020
@xzfc
Copy link
Contributor

xzfc commented Jan 7, 2020

@xzfc Can you verify that this solves your problem?

Yes, it is solved by this commit.

@andir andir merged commit 2c4c7c9 into NixOS:master Jan 7, 2020
@andir andir deleted the buildRustCrateHelpers-fix branch January 7, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants