Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calls: unstable-2019-10-29 -> 0.1.1 #77375

Merged
merged 1 commit into from
Jan 9, 2020
Merged

calls: unstable-2019-10-29 -> 0.1.1 #77375

merged 1 commit into from
Jan 9, 2020

Conversation

lheckemann
Copy link
Member

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from craigem January 9, 2020 14:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 9, 2020
@lheckemann
Copy link
Member Author

The build failure on x86_64-linux is odd, since it worked on my laptop and on aarch64-linux. Maybe it's a transient failure?

@ofborg build calls

@lheckemann
Copy link
Member Author

Alright, it succeeded this time. Something to keep an eye on though!

worldofpeace
worldofpeace approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@worldofpeace worldofpeace merged commit 75f9b2f into NixOS:master Jan 9, 2020
@lheckemann lheckemann deleted the calls-0.1.1 branch January 10, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@craigem craigem Awaiting requested review from craigem

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lheckemann @worldofpeace