Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/certmgr: Fix file permissions #77540

Merged
merged 1 commit into from
Jan 19, 2020
Merged

nixos/tests/certmgr: Fix file permissions #77540

merged 1 commit into from
Jan 19, 2020

Conversation

singron
Copy link
Contributor

@singron singron commented Jan 12, 2020

This test has been broken since 2a413da, which stopped running the
nginx master process as root.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@singron
nixos/tests/certmgr: Fix file permissions
dc6451f 
This test has been broken since 2a413da, which stopped running the
nginx master process as root.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 12, 2020
@singron
Copy link
Contributor Author

singron commented Jan 12, 2020

cc @flokli (I noticed you merged a previous PR affecting this test)

@jonringer
Copy link
Contributor

@GrahamcOfBorg test certmgr

jonringer
jonringer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
confirmed test is broken on master:

machine # [  160.289132] systemd[1]: Failed to start Nginx Web Server.
error: unit "nginx.service" reached state "failed"
cleaning up
killing machine (pid 9)
(0.00 seconds)
builder for '/nix/store/3b23rc9iqglir3kbq1rs3plagr0ffx05-vm-test-run-certmgr-systemd.drv' failed with exit code 1
error: build of '/nix/store/3b23rc9iqglir3kbq1rs3plagr0ffx05-vm-test-run-certmgr-systemd.drv' failed

@singron singron requested a review from flokli January 16, 2020 18:21
@flokli flokli merged commit 5ed3474 into NixOS:master Jan 19, 2020
@flokli
Copy link
Contributor

flokli commented Jan 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singron @jonringer @flokli