Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nnn: 2.8.1 -> 2.9 #77746

Merged
merged 2 commits into from
Jan 17, 2020
Merged

nnn: 2.8.1 -> 2.9 #77746

merged 2 commits into from
Jan 17, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 15, 2020 •
edited
Loading

Motivation for this change

https://github.com/jarun/nnn/releases/tag/v2.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested a review from jfrankenau January 15, 2020 10:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 15, 2020
@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

LGTM! Thanks!

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

Eep, holding on merge to give maintainer a chance ^_^.

@Br1ght0ne
Copy link
Member Author

I think @jfrankenau is less active currently. Can we merge this, @dtzWill? Thanks!

@dtzWill
Copy link
Member

dtzWill commented Jan 17, 2020

Sounds good, thanks for the follow-up!

@dtzWill dtzWill merged commit ed6e427 into NixOS:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Br1ght0ne @dtzWill