Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains-mono: 1.0.1 -> 1.0.2 #78409

Merged
merged 1 commit into from
Jan 24, 2020
Merged

jetbrains-mono: 1.0.1 -> 1.0.2 #78409

merged 1 commit into from
Jan 24, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 24, 2020

Motivation for this change

Changelog: https://github.com/JetBrains/JetBrainsMono/releases/tag/v1.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 24, 2020
@marsam marsam merged commit 50e6e59 into NixOS:master Jan 24, 2020
@marsam marsam deleted the update-jetbrains-mono branch January 24, 2020 23:28
@puzzlewolf puzzlewolf mentioned this pull request Apr 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsam @puzzlewolf