Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dhcpcd: Add option for dhcpcd waiting behaviour #78745

Merged
merged 1 commit into from
Jan 29, 2020
Merged

nixos/dhcpcd: Add option for dhcpcd waiting behaviour #78745

merged 1 commit into from
Jan 29, 2020

Conversation

bene1618
Copy link
Contributor

Motivation for this change

The current standard for dhcpcd is to wait for an IP address to be assigned before forking to background. This pull request adds an option networking.dhcpcd.wait which allows to configure this behaviour manually. This is a new version of #58526 which I accidentally closed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bene1618 bene1618 mentioned this pull request Jan 29, 2020
Closed
8 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 29, 2020
@worldofpeace worldofpeace merged commit c693bd1 into NixOS:master Jan 29, 2020
@worldofpeace
Copy link
Contributor

Merged because it was already approved and it was squashed like @infinisil requested.

@bene1618 bene1618 deleted the dhcpcd branch January 30, 2020 08:19
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78745 from bene1618/dhcpcd
b4672fa 
nixos/dhcpcd: Add option for dhcpcd waiting behaviour
@rnhmjoj rnhmjoj mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bene1618 @worldofpeace