Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpxlab: enable on darwin #78916

Merged
merged 1 commit into from
Jan 31, 2020
Merged

gpxlab: enable on darwin #78916

merged 1 commit into from
Jan 31, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 30, 2020

Motivation for this change

Enable on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from veprbl January 30, 2020 21:18
veprbl
veprbl approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on macOS

@veprbl veprbl merged commit f566c68 into NixOS:master Jan 31, 2020
@sikmir sikmir deleted the gpxlab branch January 31, 2020 06:22
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@veprbl @anna328p
Merge pull request NixOS#78916 from sikmir/gpxlab
4b55495 
gpxlab: enable on darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sikmir @veprbl