dnscrypt-proxy2: 2.0.36 -> 2.0.39

[Atemu]

Motivation for this change

https://github.com/DNSCrypt/dnscrypt-proxy/releases/tag/2.0.39

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[worldofpeace]

It seems you're handling updates here and contributed the module, would you like to add yourself to the maintainers of the package?

[Atemu]

That sounds like something I could do.

What exactly would that mean for me?
What responsibilities would I need to take on?
What level of experience with Nix should I have?

[Atemu]

Also, should I rebase this PR to resolve the merge conflict?

[worldofpeace]

Also, should I rebase this PR to resolve the merge conflict?

Yep.

To add yourself as a maintainer of the package you need to add your metadata at https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix, and in the maintainers meta attribute of the package

nixpkgs/pkgs/tools/networking/dnscrypt-proxy2/default.nix

Line 21 in 90dd157

maintainers = with maintainers; [ waynr ];

[Atemu]

Also, should I rebase this PR to resolve the merge conflict?

Yep.

Done.

Is that something you should generally do? I'm still pretty new to contributing to GH projects.

To add yourself as a maintainer of the package you need to add your metadata at https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix, and in the maintainers meta attribute of the package

nixpkgs/pkgs/tools/networking/dnscrypt-proxy2/default.nix

Line 21 in 90dd157

maintainers = with maintainers; [ waynr ];

Yeah, that's all pretty clear, I just wanted to be sure what it actually means to become a maintainer.

[worldofpeace]

Being a maintainer means this package is your responsibility:

• people will mention you on this package for updates or issues
• ofborg (our bot) will request your review on any change that touches this package

Also, should I rebase this PR to resolve the merge conflict?

Yep.

Done.

Is that something you should generally do? I'm still pretty new to contributing to GH projects.

In nixpkgs we prefer rebasing https://nixos.org/nixpkgs/manual/#chap-submitting-changes.
Generally, most other projects deal with merges.

[worldofpeace]

@GrahamcOfBorg test dnscrypt-proxy2

[Atemu]

Being a maintainer means this package is your responsibility:

* people will mention you on this package for updates or issues

* ofborg (our bot) will request your review on any change that touches this package

Alright, thanks.

I'll go ahead and do that then.

In nixpkgs we prefer rebasing https://nixos.org/nixpkgs/manual/#chap-submitting-changes.

More specifically https://nixos.org/nixpkgs/manual/#submitting-changes-hotfixing-pull-requests, thanks!