Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnscrypt-proxy2: 2.0.36 -> 2.0.39 #79085

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Feb 2, 2020

Motivation for this change

https://github.com/DNSCrypt/dnscrypt-proxy/releases/tag/2.0.39

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 2, 2020

It seems you're handling updates here and contributed the module, would you like to add yourself to the maintainers of the package?

@Atemu
Copy link
Member Author

@Atemu Atemu commented Feb 3, 2020

That sounds like something I could do.

What exactly would that mean for me?
What responsibilities would I need to take on?
What level of experience with Nix should I have?

@Atemu
Copy link
Member Author

@Atemu Atemu commented Feb 3, 2020

Also, should I rebase this PR to resolve the merge conflict?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 3, 2020

Also, should I rebase this PR to resolve the merge conflict?

Yep.

To add yourself as a maintainer of the package you need to add your metadata at https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix, and in the maintainers meta attribute of the package

maintainers = with maintainers; [ waynr ];

@Atemu Atemu force-pushed the Atemu:dnscrypt-proxy2-2.0.39 branch from 24be468 to 823d695 Feb 6, 2020
@Atemu
Copy link
Member Author

@Atemu Atemu commented Feb 6, 2020

Also, should I rebase this PR to resolve the merge conflict?

Yep.

Done.

Is that something you should generally do? I'm still pretty new to contributing to GH projects.

To add yourself as a maintainer of the package you need to add your metadata at https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix, and in the maintainers meta attribute of the package

maintainers = with maintainers; [ waynr ];

Yeah, that's all pretty clear, I just wanted to be sure what it actually means to become a maintainer.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 6, 2020

Being a maintainer means this package is your responsibility:

  • people will mention you on this package for updates or issues
  • ofborg (our bot) will request your review on any change that touches this package

Also, should I rebase this PR to resolve the merge conflict?

Yep.

Done.

Is that something you should generally do? I'm still pretty new to contributing to GH projects.

In nixpkgs we prefer rebasing https://nixos.org/nixpkgs/manual/#chap-submitting-changes.
Generally, most other projects deal with merges.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 6, 2020

@GrahamcOfBorg test dnscrypt-proxy2

@worldofpeace worldofpeace merged commit 12b8981 into NixOS:master Feb 6, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
dnscrypt-proxy2 on aarch64-linux Success
Details
dnscrypt-proxy2 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.dnscrypt-proxy2 on aarch64-linux Success
Details
tests.dnscrypt-proxy2 on x86_64-linux Success
Details
@Atemu
Copy link
Member Author

@Atemu Atemu commented Feb 7, 2020

Being a maintainer means this package is your responsibility:

* people will mention you on this package for updates or issues

* ofborg (our bot) will request your review on any change that touches this package

Alright, thanks.

I'll go ahead and do that then.

In nixpkgs we prefer rebasing https://nixos.org/nixpkgs/manual/#chap-submitting-changes.

More specifically https://nixos.org/nixpkgs/manual/#submitting-changes-hotfixing-pull-requests, thanks!

@Atemu Atemu mentioned this pull request Feb 7, 2020
0 of 10 tasks complete
@Atemu Atemu deleted the Atemu:dnscrypt-proxy2-2.0.39 branch Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.