Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb: mytop add "clear" to PATH #79159

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Feb 3, 2020

Motivation for this change

The following error was printed every second:

Can't exec "clear": Not a directory at /nix/store/.../bin/.mytop-wrapped line 110.
Use of uninitialized value $CLEAR in string at /nix/store/.../bin/.mytop-wrapped line 781.

Therefore the mytop output was repeatedly displayed instead of updating itself "in-place".

output

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The following error was printed every second:

    Can't exec "clear": Not a directory at /nix/store/.../bin/.mytop-wrapped line 110.
    Use of uninitialized value $CLEAR in string at /nix/store/.../bin/.mytop-wrapped line 781.

Therefore the mytop output was repeatedly displayed instead of updating itself "in-place".
@ofborg ofborg bot requested a review from thoughtpolice February 3, 2020 16:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 labels Feb 3, 2020
@aanderse
Copy link
Member

aanderse commented Feb 4, 2020

@jojosch when I originally "fixed" mytop and tested it my shell was at the perfect resolution that only quickly reviewing the output I didn't notice this. D'oh! Thanks for the PR. I'll test and merge this shortly.

@aanderse aanderse merged commit 0285cbc into NixOS:master Feb 4, 2020
@jojosch jojosch deleted the mytop-clear branch February 4, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants