Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SHA for pasystray. #7976

Merged
merged 4 commits into from
May 26, 2015
Merged

Fix SHA for pasystray. #7976

merged 4 commits into from
May 26, 2015

Conversation

mdorman
Copy link
Contributor

@mdorman mdorman commented May 24, 2015

I presume there's something about how github creates the .zip files such
that they can change SHA.

Please note: this is a very outdated version of pasystray---I don't know
if that's intentional, but perhaps a better strategy would be to update
it wholesale.

@mdorman
Copy link
Contributor Author

mdorman commented May 25, 2015

And, in fact, this now updates to the latest version of pasystray, which I've built and tested locally.

@lucabrunox
Copy link
Contributor

Use fetchzip.

@mdorman mdorman force-pushed the master-updates branch 2 times, most recently from 93f97d8 to caca49e Compare May 25, 2015 12:24
@mdorman
Copy link
Contributor Author

mdorman commented May 25, 2015

@lethalman updated.

@copumpkin
Copy link
Member

I'd suggest using fetchFromGitHub, which uses fetchzip but also abstracts out common things, so if issues arise in future we can fix (almost) all GH fetches in one place.

I presume there's something about how github creates the .zip files such
that they can change SHA.

Please note: this is a very outdated version of pasystray---I don't know
if that's intentional, but perhaps a better strategy would be to update
it wholesale.
lucabrunox pushed a commit that referenced this pull request May 26, 2015
@lucabrunox lucabrunox merged commit b53f144 into NixOS:master May 26, 2015
@lucabrunox
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants