Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-tour: init at 0.0.1 #80323

Merged
merged 1 commit into from
Mar 4, 2020
Merged

gnome-tour: init at 0.0.1 #80323

merged 1 commit into from
Mar 4, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

It was talked that gnome might recommend this as a default application for first run.
https://gitlab.gnome.org/GNOME/gnome-build-meta/issues/243, they will likely link it into gnome-initial-setup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package labels Feb 17, 2020
@ofborg ofborg bot requested review from hedning and jtojnar February 17, 2020 01:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Feb 17, 2020
@jtojnar
Copy link
Member

jtojnar commented Feb 17, 2020

Does it even work without gtk 4?

@worldofpeace
Copy link
Contributor Author

Does it even work without gtk 4?

Yes, on master they switched to gtk3 just for the purpose so it can be distributed in distro's easily.

jtojnar
jtojnar requested changes Feb 23, 2020
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the app and it looks nice but it feels like something that should be a shell extension so it could react to user’s actions. You need to leave activities to get to the next page talking again about activities.

pkgs/desktops/gnome-3/core/gnome-tour/default.nix Show resolved Hide resolved
pkgs/desktops/gnome-3/core/gnome-tour/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome-3/core/gnome-tour/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from jtojnar February 23, 2020 11:57
@worldofpeace worldofpeace marked this pull request as ready for review February 23, 2020 12:52
@worldofpeace
Copy link
Contributor Author

Didn't realize that was still a draft.

worldofpeace
worldofpeace commented Feb 24, 2020
View reviewed changes
pkgs/desktops/gnome-3/core/gnome-tour/default.nix Outdated
mesonFlags = [
"-Ddistro_name=NixOS"
"-Ddistro_icon_name=nix-snowflake"
"-Ddistro_version=20.03"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I could get this value from nixos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gitlab.gnome.org/GNOME/gnome-tour/issues/10

@worldofpeace
Copy link
Contributor Author

Hopefully today this will get its first release https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/514#note_727038, and I believe we should add it for 3.36.

@worldofpeace worldofpeace changed the title gnome-tour: init at 2020-02-15 gnome-tour: init at 0.0.1 Mar 3, 2020
@worldofpeace
Copy link
Contributor Author

Updated to release.

@worldofpeace worldofpeace merged commit 66c169a into NixOS:master Mar 4, 2020
@worldofpeace worldofpeace deleted the gnome-tour branch March 4, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @jtojnar