Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbeaver: 6.3.4 -> 6.3.5 #80349

Merged
merged 1 commit into from
Feb 17, 2020
Merged

dbeaver: 6.3.4 -> 6.3.5 #80349

merged 1 commit into from
Feb 17, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Feb 17, 2020

Motivation for this change

https://dbeaver.io/2020/02/16/dbeaver-6-3-5/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/jcny79dfj50hd7iccvwxfvg1k2wbx1z3-dbeaver-ce-6.3.4	 1214612840
/nix/store/ri20h4bkzq8vka79v9zzgq7ms6iarbmx-dbeaver-ce-6.3.5	 1214636944

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Feb 17, 2020
lsix
lsix approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested.

Everything seems fine for me.

Thanks

@lsix lsix merged commit 9992702 into NixOS:master Feb 17, 2020
@jojosch jojosch deleted the dbeaver_6.3.5 branch February 17, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojosch @lsix