google-cloud-sdk: fix Darwin build by only stripping local symbols #80554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darwin won't strip relocatable symbols, so strip only local symbols from cygrpc.so See also NixOS@6ceebc4#commitcomment-37355193
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
zimbatm
pushed a commit
that referenced
this pull request
Feb 21, 2020
…80554) Darwin won't strip relocatable symbols, so strip only local symbols from cygrpc.so See also 6ceebc4#commitcomment-37355193 (cherry picked from commit 9b8a14b)
|
also back-ported to 20.03 |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin won't strip relocatable symbols, so strip only local symbols from
cygrpc.soFrom the man page for strip(1):
Motivation for this change
Mainly to fix the build on macOS. See also 6ceebc4#commitcomment-37355193
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Please let me know if there's any other testing I should do. I don't have access to a Linux/NixOS machine right now so I couldn't test on that platform, but Hydra should check this, right?