Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dua: 2.1.11 -> 2.3.1 #80777

Merged
merged 1 commit into from
Feb 27, 2020
Merged

dua: 2.1.11 -> 2.3.1 #80777

merged 1 commit into from
Feb 27, 2020

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Feb 22, 2020

Motivation for this change

https://github.com/Byron/dua-cli#-v22-show-size-on-disk-by-default-dependency-update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working on NixOS

Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working on NixOS. For macOS it says

builder for '/nix/store/jlr979znfyxyiwrfrbijbs6w4kbrqwl1-dua-2.3.1.drv' failed with exit code 1; last 10 log lines:
  unpacking sources
  unpacking source archive /nix/store/27kbk099g60x55p80bz0r52gcg60z5p0-source
  source root is source
  unpacking source archive /nix/store/wxzi4fxpwnkvcnjvy38vxhp92rdcky1v-dua-2.3.1-vendor.tar.gz
  dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
    Referenced from: /nix/store/01fyi95rmqzc3r1pfjaqfj0xaw3r9c2c-gettext-0.20.1/lib/libintl.8.dylib
    Reason: no suitable image found.  Did find:
         /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
  /nix/store/wzarnmaz33i8qx9n858whzdkp6wfw9pr-stdenv-darwin/setup: line 840: 15020 Abort trap: 6           tar xf "$fn"

but that might be a problem on my machine.

@dywedir
Copy link
Member Author

dywedir commented Feb 25, 2020

@killercup are you OK with disabling the tests?

@ofborg ofborg bot requested a review from killercup February 25, 2020 06:21
@killercup
Copy link
Member

@killercup are you OK with disabling the tests?

Yeah, that's fine. As far as I can tell a lot of them depend on the fixtures that mess up the checksum thanks to weird unicode support in some filesystems.

@dywedir
Copy link
Member Author

dywedir commented Feb 27, 2020

Thanks for the review(s)!

@dywedir dywedir changed the title dua: 2.1.11 -> 2.3.0 dua: 2.1.11 -> 2.3.1 Feb 27, 2020
@dywedir dywedir merged commit dcba5b3 into NixOS:master Feb 27, 2020
@dywedir dywedir deleted the dua branch February 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants