-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dua: 2.1.11 -> 2.3.1 #80777
dua: 2.1.11 -> 2.3.1 #80777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed working on NixOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed working on NixOS. For macOS it says
builder for '/nix/store/jlr979znfyxyiwrfrbijbs6w4kbrqwl1-dua-2.3.1.drv' failed with exit code 1; last 10 log lines:
unpacking sources
unpacking source archive /nix/store/27kbk099g60x55p80bz0r52gcg60z5p0-source
source root is source
unpacking source archive /nix/store/wxzi4fxpwnkvcnjvy38vxhp92rdcky1v-dua-2.3.1-vendor.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
Referenced from: /nix/store/01fyi95rmqzc3r1pfjaqfj0xaw3r9c2c-gettext-0.20.1/lib/libintl.8.dylib
Reason: no suitable image found. Did find:
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/wzarnmaz33i8qx9n858whzdkp6wfw9pr-stdenv-darwin/setup: line 840: 15020 Abort trap: 6 tar xf "$fn"
but that might be a problem on my machine.
@killercup are you OK with disabling the tests? |
Yeah, that's fine. As far as I can tell a lot of them depend on the fixtures that mess up the checksum thanks to weird unicode support in some filesystems. |
Thanks for the review(s)! |
Motivation for this change
https://github.com/Byron/dua-cli#-v22-show-size-on-disk-by-default-dependency-update
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)