Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-lineup: init at 1.0.1 #80823

Merged
merged 1 commit into from
Feb 25, 2020
Merged

sonic-lineup: init at 1.0.1 #80823

merged 1 commit into from
Feb 25, 2020

Conversation

vandenoever
Copy link
Contributor

Motivation for this change

@cillianderoiste @luzpaz @ttuegel

If you like sonic-visualiser, you'll probably like this app from the same family too.

https://www.sonicvisualiser.org/sonic-lineup/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Feb 22, 2020
@cillianderoiste cillianderoiste merged commit 0079850 into NixOS:master Feb 25, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 26, 2020
@cillianderoiste @dtzWill
Merge pull request NixOS#80823 from vandenoever/sl
1fa4a18 
sonic-lineup: init at 1.0.1
(cherry picked from commit 0079850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandenoever @cillianderoiste