linux: add policy routing config flag #81415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
reviewed
Feb 29, 2020
ofborg
bot
added
10.rebuild-darwin: 0
picnoir
force-pushed
the
nin-routing-policy-aarch-kernel
branch
from
25d3a44
to
cf3cbff
Compare
|
Note: successfully calling |
samueldr
reviewed
Mar 1, 2020
picnoir
force-pushed
the
nin-routing-policy-aarch-kernel
branch
from
cf3cbff
to
c98d1ec
Compare
picnoir
changed the title
ofborg
bot
added
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
and removed
10.rebuild-linux: 0
|
Currently testing #81405 with this PR. It doesn't work... Though:
I'm waiting on a new build+test with that set. |
|
Damned, missed that dependency. Thanks for running the tests! |
picnoir
force-pushed
the
nin-routing-policy-aarch-kernel
branch
from
c98d1ec
to
1e27857
Compare
CONFIG_IP_MULTIPLE_TABLES is part of the default x86 kernel config but absent from the Aarch64 one. Adding explicitely this flag together with its dependency IP_ADVANCED_ROUTER. Both of these config flags are needed to use the routing policy facilities.
picnoir
force-pushed
the
nin-routing-policy-aarch-kernel
branch
from
1e27857
to
6896b1c
Compare
samueldr
approved these changes
Mar 1, 2020
|
With IP_ADVANCED_ROUTER = yes the test passes.
Nice!
I added the option to this PR. We should be able to merge as soon as Hydra finish to rebuild the whole world.
|
|
Thanks! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/ip-rule-address-family-not-supported-by-protocol/3166/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Continuation of #81405 (comment)
CONFIG_IP_MULTIPLE_TABLESis part of the default x86 kernel config butabsent from the Aarch64 one. Adding this flag on the aarch64 config to
align it with the x86.
I did not use any
optionguard here: it seem like this flag is supported since Linux 2.5.45 https://cateee.net/lkddb/web-lkddb/IP_MULTIPLE_TABLES.htmlDisclaimer: I do not have access to a aarch64 machine to try this out + I don't really know what I'm doing.
CC @samueldr
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Fixes #61602