terraform-providers.libvirt: 0.5.1 -> 0.6.1 #81497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know, if we need to backport it to 20.03 as well (i.e. it's libvirt is too new too.) |
Mic92
reviewed
Mar 2, 2020
|
|
||
| goPackagePath = "github.com/dmacvicar/terraform-provider-libvirt"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "dmacvicar"; | ||
| repo = "terraform-provider-libvirt"; | ||
| rev = "v${version}"; | ||
| sha256 = "0shnj5byqj3qzyqniiy1dcygd8xw1h2bx9z6mgcydw8k64fkm4bw"; | ||
| sha256 = "1lbxz75yi0vkay3iza07bbm3x3rdx54fzqsjs41xbcpihxap1fiz"; |
There was a problem hiding this comment.
I get a different checksum here using nixpkgs-review:
nix-shell -p terraform-providers.libvirt
these derivations will be built:
/nix/store/0g71whp3rzsqlxj8010mjwpppdwc70q7-source.drv
/nix/store/mqp2mcags9np697f8m6936lc39p89cs5-terraform-provider-libvirt-0.6.1.drv
building '/nix/store/0g71whp3rzsqlxj8010mjwpppdwc70q7-source.drv'...
trying https://github.com/dmacvicar/terraform-provider-libvirt/archive/v0.6.1.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 144 100 144 0 0 1241 0 --:--:-- --:--:-- --:--:-- 1241
100 21.2M 0 21.2M 0 0 8849k 0 --:--:-- 0:00:02 --:--:-- 9.9M
unpacking source archive /build/v0.6.1.tar.gz
hash mismatch in fixed-output derivation '/nix/store/a147nzk43kk7rzcda5gcay8kzxrgakmb-source':
wanted: sha256:1lbxz75yi0vkay3iza07bbm3x3rdx54fzqsjs41xbcpihxap1fiz
got: sha256:1l2n97nj6g44n7bhnbjwmv36xi6754p4iq2qnpkdh39x4384a0zz
cannot build derivation '/nix/store/mqp2mcags9np697f8m6936lc39p89cs5-terraform-provider-libvirt-0.6.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/mqp2mcags9np697f8m6936lc39p89cs5-terraform-provider-libvirt-0.6.1.drv' failed
|
It also seems like @GrahamcOfBorg get this error as well. |
gila
force-pushed
the
terraform-provider-libvirt
branch
from
73aa952
to
c1b5cfe
Compare
|
@Mic92 I do apologise, I've corrected the hash (that has was from 0.6.0 which I tried first). As for 20.x I think that would be very nice (I'm running the pre-release and hence I bumped into that and the plugin structure from terraform makes it (at least for me) very hard to override that the version of plugins (I could not get that to work at all to be honest). |
|
backport 943aff5 |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current version of the plugin does not work with nixpkgs-unstable as the libvirt daemon is to new for the old plugin
Things done
Updated the plugin and terraformed away.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)