Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsasl: export LOCALDOMAIN before running tests #81601

Merged
merged 1 commit into from
Mar 3, 2020
Merged

gsasl: export LOCALDOMAIN before running tests #81601

merged 1 commit into from
Mar 3, 2020

Conversation

andir
Copy link
Member

@andir andir commented Mar 3, 2020

Motivation for this change

Recently kerberos added a code path that relies on the local domain part
to be available. See [hydra] for the recent build failure and [github]
for a brief analysis of the error.

[hydra] https://hydra.nixos.org/build/113717403
[github]:

This unblocks nixos-unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
gsasl: export LOCALDOMAIN before running tests
6eb3154 
Recently kerberos added a code path that relies ont he local domain part
to be available. See [hydra] for the recent build failure and [github]
for a brief analysis of the error.

[hydra] https://hydra.nixos.org/build/113717403
[github]:
  - NixOS#81531 (comment)
  - NixOS#81531 (comment)
@andir andir added the 1.severity: channel blocker Blocks a channel label Mar 3, 2020
@ofborg ofborg bot requested a review from shlevy March 3, 2020 09:50
@andir
Copy link
Member Author

andir commented Mar 3, 2020

cc @mdorman @dasJ (because of #81531)

@andir
Copy link
Member Author

andir commented Mar 3, 2020 •
edited
Loading

I filed an upstream issue into the krb5 RT. Will post the link here once I have it.

dasJ
dasJ approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andir andir merged commit c708402 into NixOS:master Mar 3, 2020
@vcunat vcunat mentioned this pull request Mar 3, 2020
Merged
@andir
Copy link
Member Author

andir commented Mar 5, 2020

krb5/krb5@cd82bf3 is the upstream fix that should be in the next krb5 release

@andir andir deleted the gsasl branch March 5, 2020 21:08
@vcunat vcunat mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andir @dasJ